Fix work around #906 (#96)

- Work around IntelPython/numba-dpex#906 by moving bugged instruction patterns to `dpex.func` functions - Fix tolerance value - Implement strict convergence checking --------- Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]>
soda-inria · Feb 28, 2023 · 7b647cb · 7b647cb
1 parent e80ef78
commit 7b647cb
Show file tree

Hide file tree

Showing 16 changed files with 768 additions and 369 deletions.
diff --git a/docker/Dockerfile b/docker/Dockerfile
@@ -131,7 +131,6 @@ ARG ONEAPI_CACHE_DIR=$TMPDIR/intel/cache
 ARG ONEAPI_DOWNLOAD_DIR=$TMPDIR/intel/download
 ARG ONEAPI_LOG_DIR=$TMPDIR/intel/log
 ARG ONEAPI_COMPONENTS="intel.oneapi.lin.dpcpp-cpp-compiler:intel.oneapi.lin.tbb.devel:intel.oneapi.lin.mkl.devel"
-ARG LLVM_SPIRV_INSTALL_DIR
 RUN mkdir -p $ONEAPI_INSTALL_DIR $ONEAPI_CACHE_DIR $ONEAPI_DOWNLOAD_DIR $ONEAPI_LOG_DIR \
     && wget -P $ONEAPI_DOWNLOAD_DIR $ONEAPI_INSTALLER_URL/$ONEAPI_INSTALL_BINARY_NAME \
     && chmod +x $ONEAPI_DOWNLOAD_DIR/$ONEAPI_INSTALL_BINARY_NAME \

diff --git a/sklearn_numba_dpex/common/_utils.py b/sklearn_numba_dpex/common/_utils.py
@@ -39,11 +39,14 @@ def _plus_closure(x, y):
     return _plus_closure
 
 
-def _divide():
-    def _divide_closure(x, y):
-        return x / y
+def _divide_by(divisor):
+    def _divide_by_fn():
+        def _divide_closure(x):
+            return x / divisor
 
-    return _divide_closure
+        return _divide_closure
+
+    return _divide_by_fn
 
 
 def _check_max_work_group_size(