Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github workflows #6412

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Fix github workflows #6412

merged 5 commits into from
Aug 13, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Aug 13, 2024

Summary

  1. Fix paths
    • Workflow files have been renamed, but the paths inside the workflows weren't updated
    • Due to this mismatch the workflow is not triggered once it is edited
  2. Fix caching
    • Remove caching when building apps (it wasn't working well)

Test plan

There are failing tests, but their fail in not depending on this PR
image
image

@Latropos Latropos requested a review from tjzel August 13, 2024 08:58
Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
@Latropos Latropos requested a review from tjzel August 13, 2024 11:32
@Latropos Latropos marked this pull request as ready for review August 13, 2024 13:20
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for help!

@tjzel tjzel added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 250e39b Aug 13, 2024
30 of 39 checks passed
@tjzel tjzel deleted the acynk/ci-fixes branch August 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants