Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'distance' symbol duplication with MobileVLCKit (tools.c.o). #1420

Closed
wants to merge 1 commit into from

Conversation

notjulian
Copy link
Contributor

Related: xuyuanzhou/react-native-yz-vlcplayer#68

thanks to @ilyapavkin

Summary

Explain the motivation for making this change: here are some points to help you:

  • What issues does the pull request solve?

duplicate symbol '_distance' in:
/Users/namtran/Library/Developer/Xcode/DerivedData/xxxxx-cnkfbfmejgwnrgdjwcktivwklalt/Build/Products/Debug-iphonesimulator/RNSVG/libRNSVG.a(RNSVGPathMeasure.o)
/Users/namtran/Desktop/factorynowreact/ios/Pods/MobileVLCKit/MobileVLCKit-binary/MobileVLCKit.framework/MobileVLCKit(tools.c.o)
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1

Test Plan

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@notjulian
Copy link
Contributor Author

can you please merge this?

@notjulian notjulian closed this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants