Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate linting stage and Black/isort formatting #2

Merged
merged 18 commits into from
Aug 6, 2019
Merged

Add separate linting stage and Black/isort formatting #2

merged 18 commits into from
Aug 6, 2019

Conversation

juliotrigo
Copy link
Member

@juliotrigo juliotrigo commented Jul 24, 2019 •
edited
Loading

  • Add Black code formatting:
    • Omit checks for string quotes
    • Use default line length: 88
    • Python versions supported by Black's output: py36, py37 and py38
    • Amend code formatting
  • Amend flake8 config:
    • Add flake8-bugbear plugin
    • Amend configuration
  • Add isort code formatting:
    • Fix test order when using tox
    • Amend code formatting
  • Add pyproject.toml:
    • As described in PEP 518
    • Contains Black and isort settings
    • In preparation for additional settings to be added here soon
  • Split linting and test:
    • Avoid running linting for each one of the test jobs
    • Black does not support Python 3.5
    • Do not run linting as part of coverage
  • Add extra options to package setup:
    • Development Status: Beta
    • Python 3 only
    • keywords
  • Make pytest config fixtures more explicit so that they can be easily reused
  • Temporarily add pip-wheel-metadata to .gitignore until the following issue gets resolved: pip-wheel-metadata configurable pypa/pip#6213

@juliotrigo juliotrigo added the WIP Work in progress label Jul 24, 2019
@juliotrigo juliotrigo removed the WIP Work in progress label Jul 24, 2019
@juliotrigo juliotrigo changed the title Improve formatting and setup Add separate linting stage and Black formatting Jul 25, 2019
@juliotrigo juliotrigo changed the title Add separate linting stage and Black formatting Add separate linting stage and Black/isort formatting Jul 27, 2019
tomviner
tomviner approved these changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@tomviner tomviner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

setup.py
install_requires=['nameko>=2.6', 'redis>=2.10.5'],
extras_require={
'dev': [
'pytest~=5.0.0',
'coverage~=4.5.3',
'flake8',
'flake8-bugbear',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.travis.yml
- stage: test
python: 3.5
env: TOX_ENV="py35-nameko{2.11,2.12,latest}-redis2.10"
env: TOX_ENV="py35-nameko{2.11,2.12,latest}-redis2.10-test"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if it might be possible to simplify this config using tox-travis, but no need to do that here, as you've got it all working.

Let's create an issue for that and I'll have a go. Assuming you're sticking with travis for the moment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we're sticking with Travis CI for the time being.
It sounds good, please feel free to create an issue for that.

@juliotrigo juliotrigo merged commit 600b708 into master Aug 6, 2019
@juliotrigo juliotrigo deleted the formatting_and_setup branch August 6, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomviner tomviner tomviner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip-wheel-metadata configurable
2 participants
@juliotrigo @tomviner