This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
remove index hash calculation as an option #23928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
mar82
branch
3 times, most recently
from
fc94c14 to
8a53040
Compare
t-nelson
reviewed
Mar 25, 2022
validator/src/main.rs
Outdated
| @@ -1617,15 +1617,12 @@ pub fn main() { | |||
| .arg( | |||
| Arg::with_name("accounts_db_index_hashing") | |||
| .long("accounts-db-index-hashing") | |||
| .help("Enables the use of the index in hash calculation in \ | |||
| AccountsHashVerifier/Accounts Background Service."), | |||
| .help("This is obsolete. The accounts hash is only calculated without using the index."), | |||
There was a problem hiding this comment.
Suggested change
| .help("This is obsolete. The accounts hash is only calculated without using the index."), | |
| .hidden(true), |
validator/src/main.rs
Outdated
| .help("This is obsolete. See --accounts-db-index-hashing. \ | ||
| Disables the use of the index in hash calculation in \ | ||
| AccountsHashVerifier/Accounts Background Service."), | ||
| .help("This is obsolete. The accounts hash is only calculated without using the index."), |
There was a problem hiding this comment.
Suggested change
| .help("This is obsolete. The accounts hash is only calculated without using the index."), | |
| .hidden(true), |
jeffwashington
force-pushed
the
mar82
branch
3 times, most recently
from
2e8be37 to
91b41f4
Compare
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
(cherry picked from commit c24de17) # Conflicts: # validator/src/main.rs
jeffwashington
added a commit
that referenced
this pull request
Mar 29, 2022
(cherry picked from commit c24de17) # Conflicts: # validator/src/main.rs
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Performance will not continue to scale with the index-based hash calculation. We are no longer in transition, so eliminate the cli args controlling the transition.
Summary of Changes
Fixes #