Add MSG_WAITFORONE.try_into().unwrap() to deal with different type signature on musl libc
#29369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why hasn't it been merged yet? See it's clear |
|
Can you please run |
|
Looks like this is failing on the audit check, which was fixed in #29587 -- could you rebase and try one more time? |
|
I'm so sorry, it looks like this needs one more rebase. Can you try that one more time and ping me so I can run CI right away? |
|
Thanks for your patience, all good finally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Related: #28156 , rust-lang/libc#2945
As mentioned in the related issues, due to musl changing the type signature of
recvmmsg, solana-streamer cannot compile for targetx86_64-unknown-linux-musl.Summary of Changes
Adding a
try_into().unwrap()allows rustc to infer the arg type so that it works for both glibc and musl.Note that libc is in the process of making a breaking change for this, starting with deprecating the flags: rust-lang/libc#2963 . This change should just serve as a temporary workaround until that change lands.
Fixes #28156