Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indicate that test-checks.sh requires cargo-hack #33519

Merged
merged 1 commit into from
Oct 10, 2023
Merged

indicate that test-checks.sh requires cargo-hack #33519

merged 1 commit into from
Oct 10, 2023

Conversation

jbiseda
Copy link
Contributor

@jbiseda jbiseda commented Oct 4, 2023

Problem

test-checks.sh output for missing cargo-hack could be more helpful:

...
+ exec cargo +nightly-2023-09-20 hack --version --verbose
error: no such command: `hack`

	Did you mean `check`?
...

Summary of Changes

Add error message indicating that cargo-hack is a package that should be installed.

Fixes #

@jbiseda jbiseda force-pushed the jbiseda/cargo-hack-warning branch from 8c063f7 to 3ba20f8 Compare October 4, 2023 01:45
@jbiseda jbiseda changed the title indicate that cargo hack should be installed indicate that test-checks.sh requires cargo-hack Oct 4, 2023
@jbiseda jbiseda force-pushed the jbiseda/cargo-hack-warning branch from 3ba20f8 to 457c339 Compare October 6, 2023 21:07
@jbiseda jbiseda force-pushed the jbiseda/cargo-hack-warning branch from 457c339 to 3a764c7 Compare October 6, 2023 21:08
@jbiseda jbiseda marked this pull request as ready for review October 6, 2023 22:14
@jbiseda jbiseda requested review from ryoqun and t-nelson October 6, 2023 22:14
ryoqun
ryoqun approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbiseda jbiseda merged commit 8c27d8b into solana-labs:master Oct 10, 2023
4 checks passed
@jbiseda jbiseda deleted the jbiseda/cargo-hack-warning branch October 10, 2023 19:10
@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryoqun ryoqun ryoqun approved these changes

@t-nelson t-nelson Awaiting requested review from t-nelson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbiseda @ryoqun