Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow test feature to skip rewrites #33851

Merged
merged 13 commits into from
Oct 27, 2023
Merged

allow test feature to skip rewrites #33851

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c2e406b
allow test feature to skip rewrites
jeffwashington Oct 24, 2023
d2868a5
hook up cli arg for test skip rewrites, update tests
Oct 25, 2023
fa36141
fix sanity checker
Oct 25, 2023
b6ebeb7
add account hash to abi to fix a test
Oct 25, 2023
238dda6
reviews
Oct 25, 2023
d596446
use hashmap to collect skip_rewrites. exclude skip_rewrites from dirty
Oct 25, 2023
1ae5737
accumulate skipped_rewrite in reduce
Oct 25, 2023
561b9a4
mutex
Oct 26, 2023
d986234
fmt
Oct 26, 2023
41c5fd6
skip hash verify for this test flag
Oct 26, 2023
b6bf790
add skipped rewrites num stat
Oct 26, 2023
70c1c01
skip bank hash verify not account hash verify
Oct 26, 2023
48c875d
reviews
Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion accounts-db/src/accounts_hash.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,7 +1243,7 @@ pub enum ZeroLamportAccounts {

/// Hash of an account
#[repr(transparent)]
#[derive(Debug, Copy, Clone, Eq, PartialEq, Pod, Zeroable)]
#[derive(Debug, Copy, Clone, Eq, PartialEq, Pod, Zeroable, AbiExample)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is caused by the addition of the rewrites on Bank?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.

pub struct AccountHash(pub Hash);

// Ensure the newtype wrapper never changes size from the underlying Hash
Expand Down