snapshot test requires using snapshot archives at startup #33885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33885 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 809 809
Lines 217824 217824
=======================================
+ Hits 178351 178364 +13
+ Misses 39473 39460 -13 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The local cluster
test_incremental_snapshot_download_with_crossing_full_snapshot_interval_at_startuptest fails when turning on fastboot by default (see #33883).Summary of Changes
Explicitly turn off fastboot for this test, since it requires booting from snapshot archives as part of its asserts.
Note, the behavior doesn't actually change with this PR. It prevents behavior change from #33883.