Consolidate repeated code in Rocks::open() #34131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function matches the access type and calls a different RocksDB function depending on whether we have primary or secondary access. But, lots of the code is the same for these two paths so de-duplicate the repeated sections.
steviez
force-pushed
the
bstore_open_cleanup
branch
from
902beab to
d796f90
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34131 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 818 818
Lines 219939 219933 -6
=========================================
- Hits 180219 180173 -46
- Misses 39720 39760 +40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The function matches the access type and calls a different RocksDB function depending on whether we have primary or secondary access. But, lots of the code is the same for these two paths so de-duplicate the repeated sections.