storage-bigtable: delete entry rows if they exist when deleting confirmed block #34261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#34099 added entry-upload to bigtable upload functionality, but did not hook up delete functionality
Summary of Changes
Extend
delete_confirmed_block()
to delete entry rows if they existIf the entries table doesn't exist yet, or if the slot in question doesn't have an entry row, output says:
This is so delete will still work elegantly on old slots and on bigtables not yet updated for entries.
Otherwise, output says this: