[program-test] adding method warp_to_epoch #34620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks, this looks useful. One formatting nit.
@joncinque , can you take a look and see if you have any concerns?
program-test/src/lib.rs
Outdated
| @@ -65,6 +65,7 @@ use { | |||
| tokio::task::JoinHandle, | |||
| }; | |||
| // Export types so test clients can limit their solana crate dependencies | |||
| use solana_sdk::clock::Epoch; | |||
There was a problem hiding this comment.
Please add this to the common use statement above (L33)
There was a problem hiding this comment.
Fixed. Hopefully in the way you suggested.
There was a problem hiding this comment.
Fixed. Hopefully in the way you suggested.
joncinque
reviewed
Jan 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34620 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 824 824
Lines 222260 222264 +4
=======================================
+ Hits 181885 181951 +66
+ Misses 40375 40313 -62 |
CriesofCarrots
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The program test contains only method to warping to a particular slot. It would be nice to have a way to easily warp per epoch. The method https://github.com/solana-labs/solana/blob/v1.17.7/ledger-tool/src/main.rs#L3447 provides the calculation of the number of slots per epoch.
It could be then mapped to e.g.,
bankrunto profit from kevinheavey/solana-bankrun#13Summary of Changes
New method
warp_to_epochfor the tests.