Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces fs-err in snapshot_utils.rs #34908

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jan 23, 2024

Problem

We're trying to remove the fs-err crate. For more information, please refer to #34838.

snapshot_utils.rs still uses fs-err, but doesn't need to.

Summary of Changes

Removes fs_err from snapshot_utils.rs

Each piece is its own commit:

  • Replaces fs-err in streaming_snapshot_dir_files()
  • Replaces fs-err in serialize_snapshot_data_file_capped()
  • Replaces fs-err in create_snapshot_meta_files_for_unarchived_snapshot()
  • Replaces fs-err in create_snapshot_data_file_stream()
  • Removes fs-err import

@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Jan 23, 2024
@brooksprumo brooksprumo self-assigned this Jan 23, 2024
@brooksprumo brooksprumo removed the work in progress This isn't quite right yet label Jan 23, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 23, 2024 17:03
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ff511e) 81.6% compared to head (2b553f5) 81.6%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34908   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         827      827           
  Lines      223884   223884           
=======================================
+ Hits       182841   182865   +24     
+ Misses      41043    41019   -24     

@brooksprumo brooksprumo requested a review from HaoranYi January 23, 2024 18:17
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit e74f04a into solana-labs:master Jan 23, 2024
37 checks passed
@brooksprumo brooksprumo deleted the errors/snapshot-utils branch January 23, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants