Skip to content

Commit

Permalink
Exclude Rails 7.1 from the installer
Browse files Browse the repository at this point in the history
Rails 7.1 is not yet supported, until then we should not attempt
installing Solidus with it.
  • Loading branch information
elia committed Oct 6, 2023
1 parent 791ffcc commit 5170a8e
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,24 +156,24 @@ commands:
ruby -v >> /tmp/.ruby-versions
gem --version >> /tmp/.gems-versions
bundle --version >> /tmp/.gems-versions
gem search -eq rails >> /tmp/.gems-versions # get the latest rails from rubygems
gem search -eq rails -v "~> 7" -v"< 7.1" >> /tmp/.gems-versions # get the latest rails from rubygems
gem search -eq solidus >> /tmp/.gems-versions # get the latest solidus from rubygems
cat /tmp/.ruby-versions
cat /tmp/.gems-versions
- restore_cache:
keys:
- solidus-installer-v8-{{ checksum "/tmp/.ruby-versions" }}-{{ checksum "/tmp/.gems-versions" }}
- solidus-installer-v8-{{ checksum "/tmp/.ruby-versions" }}-
- solidus-installer-v9-{{ checksum "/tmp/.ruby-versions" }}-{{ checksum "/tmp/.gems-versions" }}
- solidus-installer-v9-{{ checksum "/tmp/.ruby-versions" }}-
- run:
name: "Prepare the rails application"
command: |
cp core/spec/solidus_install_coverage.rb /tmp/solidus_install_coverage.rb
cd /tmp
test -d my_app || gem install rails solidus
test -d my_app || (gem install rails -v "< 7.1" && gem install solidus)
test -d my_app || rails new my_app --skip-git
- save_cache:
key: solidus-installer-v8-{{ checksum "/tmp/.ruby-versions" }}-{{ checksum "/tmp/.gems-versions" }}
key: solidus-installer-v9-{{ checksum "/tmp/.ruby-versions" }}-{{ checksum "/tmp/.gems-versions" }}
paths:
- /tmp/my_app
- /home/circleci/.rubygems
Expand Down Expand Up @@ -228,7 +228,8 @@ commands:
mkdir -p /tmp/dummy_extension
cd /tmp/dummy_extension
bundle init
bundle add rails sqlite3 <<parameters.extra_gems>> --skip-install
bundle add rails -v "< 7.1" --skip-install
bundle add sqlite3 <<parameters.extra_gems>> --skip-install
bundle add solidus --path "$(ruby -e"puts File.expand_path ENV['CIRCLE_WORKING_DIRECTORY']")"
export LIB_NAME=set # dummy requireable file
bundle exec rake -rrails -rspree/testing_support/extension_rake -e'Rake::Task["extension:test_app"].invoke'
Expand Down

0 comments on commit 5170a8e

Please sign in to comment.