Merge pull request #351 from athal7/returns-in-order-management-permi…

…ssions Flesh out the returns permissions for order display/management
solidusio · Sep 3, 2015 · 81cbc5c · 81cbc5c
2 parents 34ddf88 + a1d2851
commit 81cbc5c
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/core/app/models/spree/permission_sets/order_display.rb b/core/app/models/spree/permission_sets/order_display.rb
@@ -9,6 +9,10 @@ def activate!
         can [:display, :admin], Spree::LineItem
         can [:display, :admin], Spree::ReturnAuthorization
         can [:display, :admin], Spree::CustomerReturn
+        can [:display, :admin], Spree::OrderCancellations
+        can [:display, :admin], Spree::Reimbursement
+        can [:display, :admin], Spree::ReturnItem
+        can [:display, :admin], Spree::Refund
       end
     end
   end

diff --git a/core/app/models/spree/permission_sets/order_management.rb b/core/app/models/spree/permission_sets/order_management.rb
@@ -11,6 +11,9 @@ def activate!
         can :manage, Spree::ReturnAuthorization
         can :manage, Spree::CustomerReturn
         can :manage, Spree::OrderCancellations
+        can :manage, Spree::Reimbursement
+        can :manage, Spree::ReturnItem
+        can :manage, Spree::Refund
       end
     end
   end

diff --git a/core/spec/models/spree/permission_sets/order_display_spec.rb b/core/spec/models/spree/permission_sets/order_display_spec.rb
@@ -26,6 +26,9 @@
     it { is_expected.to be_able_to(:admin, Spree::CustomerReturn) }
     it { is_expected.to be_able_to(:edit, Spree::Order) }
     it { is_expected.to be_able_to(:cart, Spree::Order) }
+    it { is_expected.to be_able_to(:display, Spree::Reimbursement) }
+    it { is_expected.to be_able_to(:display, Spree::ReturnItem) }
+    it { is_expected.to be_able_to(:display, Spree::Refund) }
   end
 
   context "when not activated" do
@@ -44,6 +47,9 @@
     it { is_expected.not_to be_able_to(:admin, Spree::ReturnAuthorization) }
     it { is_expected.not_to be_able_to(:admin, Spree::CustomerReturn) }
     it { is_expected.not_to be_able_to(:cart, Spree::Order) }
+    it { is_expected.not_to be_able_to(:display, Spree::Reimbursement) }
+    it { is_expected.not_to be_able_to(:display, Spree::ReturnItem) }
+    it { is_expected.not_to be_able_to(:display, Spree::Refund) }
   end
 end
 
diff --git a/core/spec/models/spree/permission_sets/order_management_spec.rb b/core/spec/models/spree/permission_sets/order_management_spec.rb
@@ -19,6 +19,9 @@
     it { is_expected.to be_able_to(:manage, Spree::CustomerReturn) }
     it { is_expected.to be_able_to(:display, Spree::ReimbursementType) }
     it { is_expected.to be_able_to(:manage, Spree::OrderCancellations) }
+    it { is_expected.to be_able_to(:manage, Spree::Reimbursement) }
+    it { is_expected.to be_able_to(:manage, Spree::ReturnItem) }
+    it { is_expected.to be_able_to(:manage, Spree::Refund) }
   end
 
   context "when not activated" do
@@ -31,6 +34,9 @@
     it { is_expected.not_to be_able_to(:manage, Spree::CustomerReturn) }
     it { is_expected.not_to be_able_to(:display, Spree::ReimbursementType) }
     it { is_expected.not_to be_able_to(:manage, Spree::OrderCancellations) }
+    it { is_expected.not_to be_able_to(:manage, Spree::Reimbursement) }
+    it { is_expected.not_to be_able_to(:manage, Spree::ReturnItem) }
+    it { is_expected.not_to be_able_to(:manage, Spree::Refund) }
   end
 end