-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update importing fonts.googleapis.com to use SSL
On 23/11/2021, google started to require ssl to access `//fonts.googleapis.com/css`, causing the import in the solidus frontend stylesheet to fail in CI. This breaks solidus and tests that run against the solidus_frontend. We can resolve this by explicitly using the https protocol. Error example: app.circleci.com/pipelines/github/solidusio/solidus/2791/workflows/e62ff646-9ae6-4e65-b20f-e1f7a109d3a1/jobs/26572 Blocking of this URL in testing_support was updated to bring it inline with how url's are blacklisted in future solidus versions. Even though solidus 2.9 is at end of life, some solidus extensions still test and maintain support against this version of solidus, such as SuperGoodSoft/solidus_taxjar. Co-authored-by: Ryan Woods <[email protected]>
- Loading branch information
1 parent
6c5f2ac
commit d07f5c2
Showing
3 changed files
with
26 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# frozen_string_literal: true | ||
|
||
module Spree | ||
module TestingSupport | ||
module BlacklistUrls | ||
def setup_url_blacklist(browser) | ||
if browser.respond_to?(:url_blacklist) | ||
browser.url_blacklist = ['https://fonts.googleapis.com'] | ||
end | ||
end | ||
end | ||
end | ||
end | ||
|
||
RSpec.configure do |config| | ||
config.before(:each, type: :feature) do | ||
setup_url_blacklist(page.driver.browser) | ||
end | ||
|
||
config.before(:each, type: :system) do | ||
setup_url_blacklist(page.driver.browser) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters