Conditionally call OrderUpdater#run_hooks

As the method is deprecated, we should limit calling it to only when strictly necessary, ie when there's some actual hook to be executed.
solidusio · Mar 20, 2020 · e079812 · e079812
1 parent d860b8e
commit e079812
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/app/models/spree/order.rb b/core/app/models/spree/order.rb
@@ -440,7 +440,7 @@ def finalize!
 
       updater.update_shipment_state
       save!
-      updater.run_hooks
+      update_hooks.any? && updater.run_hooks
 
       touch :completed_at
 

diff --git a/core/app/models/spree/order_updater.rb b/core/app/models/spree/order_updater.rb
@@ -26,7 +26,7 @@ def update
           update_shipments
           update_shipment_state
         end
-        run_hooks
+        update_hooks.any? && run_hooks
         Spree::Event.fire 'order_recalculated', order: order
         persist_totals
       end