Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 2.7 warnings #3611

Closed
softr8 opened this issue May 7, 2020 · 2 comments
Closed

Ruby 2.7 warnings #3611

softr8 opened this issue May 7, 2020 · 2 comments

Comments

@softr8
Copy link
Contributor

softr8 commented May 7, 2020

The following warnings are thrown when running Solidus with Ruby 2.7:

  • core/lib/spree/preferences/preferable.rb:162: warning: deprecated Object#=~ is called on TrueClass; it always returns nil
  • core/app/models/concerns/spree/user_address_book.rb:8: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
  • core/lib/spree/i18n.rb:34: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
@jacquesporveau jacquesporveau mentioned this issue May 8, 2020
Merged
5 tasks
@jacquesporveau
Copy link
Contributor

I've opened up a PR for the first warning.

@softr8
Copy link
Contributor Author

softr8 commented Aug 24, 2020

Fist and second were fixed here #3737

@softr8 softr8 closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@softr8 @jacquesporveau