Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby 2.7 warnings on core #3737

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Fix ruby 2.7 warnings on core #3737

merged 2 commits into from
Aug 24, 2020

Conversation

stefano-sarioli
Copy link
Contributor

Description

Ruby 2.7 enabled some new warnings on how you can pass default and hash parameters to a function.
This PR fixes the warning inside our core code, the remaining on the core are coming from some external gems, I'm going to open issues on the affected gems about this.

I thought that doing one component at a time, instead of all the code at once, can create enable reviews and avoid some small errors that can be missed when doing repetitive tasks like this one.

Let me know what you think about this.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefano-sarioli thank you!

@aldesantis
Copy link
Member

Thanks @stefano-sarioli!

@aldesantis aldesantis merged commit 4b2fe47 into solidusio:master Aug 24, 2020
@softr8 softr8 mentioned this pull request Aug 24, 2020
@stefano-sarioli stefano-sarioli deleted the stefano-sarioli/fix-ruby-2.7-warnings-on-core branch September 22, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants