Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some currencies formatting changed using the last Money gem version #3903

Closed
kennyadsl opened this issue Jan 20, 2021 · 0 comments
Closed

Some currencies formatting changed using the last Money gem version #3903

kennyadsl opened this issue Jan 20, 2021 · 0 comments
Labels
type:bug Error, flaw or fault

Comments

@kennyadsl
Copy link
Member

We have a failing spec in master due to a change in the last minor version of the Money gem (v6.14.0). I already opened an issue on their project here: RubyMoney/money#966, trying to describe what changed but I'm not sure it will be considered as a breaking change and reverted, at least partially.

The failing spec on our side is due to a comparison that we make between the formatting provided by Money and another JS formatting library that we use (accounting.js). This comparison is showing clearly that some currency formatting changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error, flaw or fault
Projects
None yet
Development

No branches or pull requests

1 participant