Change navigation and button labels #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandily
force-pushed
the
improve-nav-labels
branch
3 times, most recently
from
ee99b5b to
5801cf8
Compare
|
👍 Looks good to me |
| one: Taxon | ||
| other: Taxons | ||
| one: Display Order | ||
| other: Display Order |
There was a problem hiding this comment.
I don't believe that this change is safe to make.
There was a problem hiding this comment.
Safe from a technical or user perspective? I'm not sure of an alternative if it's code, but if it's the user you're worried about, we could use an interim 'Display Order (Taxon)' label that would be intuitive for familiar users and new users alike.
To clarify - this is only affecting the page title of this page:
The taxonomy tree still stays the same, and we're not getting rid of the 'taxon' terminology.
Mandily
force-pushed
the
improve-nav-labels
branch
from
5801cf8 to
b847e67
Compare
|
There are some failing tests now that the Taxon translation change has been reverted. Other than that, this is looking good. |
Some labels were inconsistent and some were confusing. Based on a recent card sort and tree test on the navigation, I was able to figure out where some problem areas were. I've fixed the inconsistencies and made the confusing labels more clear. I've also updated the tests to reflect the new labels.
Mandily
force-pushed
the
improve-nav-labels
branch
from
b847e67 to
285f129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor to #1120
Some labels were inconsistent and some were confusing.
Based on a recent card sort and tree test on the navigation, I was able to figure out where some problem areas were. I've fixed the inconsistencies and made the confusing labels more clear.