Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move product SKUs list to a tooltip hint #1316

Conversation

isaacfreeman
Copy link

When editing products with multiple SKUs, we have some explanatory text and a list of five SKUs. This was intended to help beginners understand why they can't edit the SKU for a product, and guide them to editing the variants instead.

Now that we have tooltip hints in admin, it's tidier to move the list of SKUs into one of those. As a side-effect, we no longer have to limit the list to five SKUs, as the text isn't cluttering up the visible edit page.

One downside is that we lose links to edit the variants. However, the Manage Variants link is still present, and arguably provides more guidance for beginners to understand the relationship between products and variants.

Isaac Freeman added 2 commits July 11, 2016 14:30
- lists all product SKUs in a hint
- removes unused locale text
- removes `display: block` from `span.info`
- surrounds multiple SKUs info with a div for mroe convenient Defacing
@tvdeyen
Copy link
Member

tvdeyen commented Jul 11, 2016

👍 Fine with it.
Please squash the "fixing commit" into the previous one. It does not provide value in the git history. Thanks

@jhawthorn jhawthorn added UI changelog:solidus_backend Changes to the solidus_backend gem labels Jul 11, 2016
@jhawthorn
Copy link
Contributor

Thanks isaacfreeman

Here's a screenshot

I like that this cleans up the page, but am unsure if this is better for usability. Variants often have similar SKU's (MY_PRODUCT_BLACK, MY_PRODUCT_BLUE) and it might be helpful to be able to see that at a glance. It's only marginally more difficult to see this, but it is still slightly more difficult.

I don't have a strong opinion for or against this change. The code changes looks good.

@jrochkind
Copy link
Contributor

I think it would probably be better to still see the SKU's without a tooltip hover. They are the main identifying features of a product for many of our customers. Keep in mind you can search products by sku, it's potentially confusing to require a click and a hover to see the thing you searched for to verify you got the thing you wanted.

@Mandily
Copy link
Contributor

Mandily commented Jul 11, 2016

If this is main identifying information it shouldn't be hidden. The tooltips were created for adding supplementary information, not hiding main content. Once we get the new layout in, we'll have lots of space to list all of the variants attached to a product instead of limiting to just 5. There's a wireframe in #1290 of the products page with a variants section in the sidebar that could easily expand to fit all variant types.

My vote is to leave it as is and expand it to all variants once the new layouts are in.

@mamhoff
Copy link
Contributor

mamhoff commented Jul 11, 2016

I agree with @Mandily and @jhawthorn about this not being an explanation, but actual content.

@jasonfb
Copy link

jasonfb commented Jul 11, 2016

We have products with over 200+ SKUs, so keep in mind how this might scale with larger data sets. For the most part, there is only 1 single user of this screen at my company (the Merchandise Manager), and he's enough of a 'power user' to not really care about little bells & whistles (and to mostly know what he's doing). He does SKU-level (variant-level) management primarily from the Variants & Stock Management screens, of course.

@isaacfreeman
Copy link
Author

Well, I'm glad to hear that people like having the SKUs there, as making them visible was my first contribution to Spree! I originally intended the list of SKUs to be a temporary half-step, with the goal of eventually merging the variants table into the main product edit page.

I certainly agree that a tooltip is the wrong UI component for this job. I do think though that we need something to keep long lists of variants under control, and I'm not very happy with the "and N others" solution I originally used for lists longer than five items. If it's valuable to see the SKUs (and have them rendered as links to the variants) then it's somewhat arbitrary to say you need to go to the variants page to see the sixth one.

How would people feel about using a collapse widget instead of a tooltip? The design would be similar to the existing one, with the addition that "and N others" would be clickable to reveal what those N other SKUs actually are. That would keep long lists under control, but keep the full list of SKUs a click away instead of making admins visit the variants page.
Off the top of my head, I can't think of another place in Solidus admin that has a collapse widget, so
this would add a new UI element. On the other hand, this list of SKUs is already a bit of a departure.

Alternatively, if the consensus is that "and N others" is sufficient and we don't need any changes, then I'm fine to close the issue. With proper UX work now being done, I'm confident that there's an end in sight to my original temporary solution.

@tvdeyen
Copy link
Member

tvdeyen commented Jul 12, 2016

After reading the comments of Amanda, I need to revert my thumb and second the idea of putting the list into some "additional third column". Also, I vote for closing this now (although I appreciate the contribution).

We really should put lots of effort into #1290

@isaacfreeman
Copy link
Author

OK, closing this.

@isaacfreeman isaacfreeman deleted the feature/hint_for_multiple_skus branch July 12, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants