fixing the promotion categories error message #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind squashing the two commits into one and adding a meaningful commit message explaining this change? You'll have to rebase onto the current master anyways, and it'd be really nice if this not-so-obvious change would be somewhat more well-documented. Otherwise, this looks good. I'm especially happy you added specs for the fixed behaviour. Thank you! |
mgharbik
force-pushed
the
small-fix-promotion-categories
branch
2 times, most recently
from
597eed8 to
c911e53
Compare
|
@mamhoff I just sent you another PR. Thank you too for the tips! |
mgharbik
force-pushed
the
small-fix-promotion-categories
branch
from
c911e53 to
4886b12
Compare
|
Could you please rebase on current master? Thanks |
tvdeyen
added
needs work
changelog:solidus_backend
houndci-bot
reviewed
Jan 28, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/ElseAlignment has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/ClosingParenthesisIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineMethodCallIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/IndentArray has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout .rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout .rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout Error: The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. (obsolete configuration found in .rubocop.yml, please update it)
…1346 - fixing the error messages display for promotion categories - displaying no resources found if no promotion categories - adding features specs for promotion categories
mgharbik
force-pushed
the
small-fix-promotion-categories
branch
from
dd6c361 to
9f444f0
Compare
|
@tvdeyen sorry for the late replay! Please check it now! |
|
Sorry that this took so long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.