Correct behavior of Order#outstanding_balance #1557
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue in
Spree::Order#outstanding_balance
, incircumstances where an Order has had refunds applied.
The existing behaviour cancels out the amount of refunded payments,
resulting in a negative outstanding balance and an order state of
'credit_due', when in fact the order balance is zero. This is caused by
the calculation of
payment_total
already factoring in refunds.Some more discussion about this behaviour can be found in the following
issues:
#1107
#1536
With these changes,
outstanding_balance
is now defined astotal - payment_total
. This corrects the behaviour around refunds.Tests have been updated accordingly, with some help from
DanielePalombo's commit:
c851404