Remove use of require_tree in admin javascripts #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
requested changes
Nov 24, 2016
| //= require spree/backend/address_states | ||
| //= require spree/backend/adjustments | ||
| //= require spree/backend/admin | ||
| //= require spree/backend/backbone-overrides |
There was a problem hiding this comment.
You already required this in L15
jhawthorn
force-pushed
the
remove_require_tree
branch
from
8c870eb to
6a7d363
Compare
|
Using this fix in my demo app https://github.com/tvdeyen/solidus-asset-override-demo works 👍 |
cbrunsdon
approved these changes
Nov 25, 2016
|
This actually needs to be deployed somewhere in order to confirm its really working. My demo app is a proof though, but I want to be extra sure 😎
|
tvdeyen
approved these changes
Nov 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came out of discussion with @tvdeyen
When we use
require_treeor a relative path torequire, it makes it so that attempting to override these files in your own app won't work.This PR replaces all
require_relativecalls with an individual hardcodedrequireper-file. Requires for templates were split into their ownindex.jsfileFixes #1567