Allow twitter_cldr 4.x #1732
Merged
Allow twitter_cldr 4.x #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has updated unicode information, and may be kept more up to date with ruby 2.4 deprecations in the future. Should otherwise be backwards compatible. https://github.com/twitter/twitter-cldr-rb/blob/master/CHANGELOG.md I chose to keep allowing twitter_cldr 3.x too, for backwards compat, in case there's an incompatible dependency somewhere. But an alternate choice would be to allow only ~> 4.0.
|
To be clear, the twitter_cldr API is, I think, strictly backwards compat, but some unicode transformations and validations may differ, due to updated unicode info. I think it makes sense for the gemspec to continue allowing twitter_cldr 3.x as well as 4.x, to not force people to update if they don't want to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has updated unicode information, and may be kept more up to date
with ruby 2.4 deprecations in the future. Should otherwise be
backwards compatible. https://github.com/twitter/twitter-cldr-rb/blob/master/CHANGELOG.md
I chose to keep allowing twitter_cldr 3.x too, for backwards compat,
in case there's an incompatible dependency somewhere. But an alternate
choice would be to allow only ~> 4.0.