Disable rubocop Metrics/BlockLength #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cop was added to rubocop a few months ago. I agree shorter blocks are usually better but this doesn't seem like it's something we need in rubocop and it also has some issues with specs apparently.
jhawthorn
approved these changes
Feb 24, 2017
|
There is a better option I think, we can disable this for the specs but still have it for the system. Ran into this some time ago as well: solidusio/solidus_affirm@106096c |
|
I don't really care for any of the rules in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop was added to rubocop a few months ago. I agree shorter blocks are
usually better but this doesn't seem like it's something we need in rubocop and
it also has some issues with specs apparently.
I noticed because it started spamming this PR: #1707