Simplified cart link url #1757
Merged
Simplified cart link url #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for the link to include protocol and hostname. Scenario: A setup with a reverse proxy server in front the the application server. The Application server runs HTTP. The reverse proxy server runs HTTPS. When the reverse proxy server serves it as https, it will not load the XHR from a http: location.
|
@bofrede you may want to make sure your reverse proxy sends |
jhawthorn
approved these changes
Mar 6, 2017
cbrunsdon
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for the link to include protocol and hostname.
Scenario: A setup with a reverse proxy server in front the the application server.
The Application server runs HTTP. The reverse proxy server runs HTTPS.
When the reverse proxy server serves it as https, it will not load the XHR from a http: location.