Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated require in shipment factory #1769

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Remove duplicated require in shipment factory #1769

merged 1 commit into from
Mar 15, 2017

Conversation

upinetree
Copy link
Contributor

@upinetree upinetree commented Mar 13, 2017 •
edited
Loading

It seems to be duplicated with the line 2.

jhawthorn
jhawthorn approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks.

cbrunsdon
cbrunsdon approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@cbrunsdon cbrunsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me, thanks a lot 👍

@jhawthorn jhawthorn merged commit ec58304 into solidusio:master Mar 15, 2017
@upinetree upinetree deleted the duplicated-require branch August 22, 2017 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrunsdon cbrunsdon cbrunsdon approved these changes

@jhawthorn jhawthorn jhawthorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@upinetree @jhawthorn @cbrunsdon