Show focused border on currency selector #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were embedding the currency selector inside of a bootstrap input-group-addon and hiding its border. This required a little extra magic because we had to hide the select's border and change its height to fit within. Having no border meant that there was no indication when the currency input was focused. Bootstrap doesn't fully support having multiple inputs within a input-group, but we can make it work by hiding the right border on the left input. A slight hack is needed to make focus look correct: we show the focused colour on the right input's left border when the left border is focused. This achieves the desired effect.
jhawthorn
force-pushed
the
currency-selector-take-two
branch
from
ee823fa to
0c3aa44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were embedding the currency selector inside of a bootstrap input-group-addon and hiding its border. This required a little extra magic because we had to hide the select's border and change its height to fit within.
Having no border meant that there was no indication when the currency input was focused.
Bootstrap doesn't fully support having multiple inputs within a input-group, but we can make it work by hiding the right border on the left input.
A slight hack is needed to make focus look correct: we show the focused colour on the right input's left border when the left border is focused. This achieves the desired effect.
The focused border colour is wrong here because our current version of bootstrap's
.custom-selecthardcodes it. This will be fixed in #1816, so that should be merged first.