Fixes for users tables and forms #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the nested col-9 to let the table consume all of the available space.
Removed the nested col-9 to let the table consume all of the available space.
In order to match the rest of the admin tables we also use a fieldset and a legend to display the users current store credit balance.
Removes a nested .col-12 to let the addresses form consume all of the available space.
The user addresses form didn’t used select2 for country and state select.
Removed a nested .col-9 from the users acount form, so it can consume all of the available space.
mamhoff
approved these changes
Apr 7, 2017
jhawthorn
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These views really was lacking some love.
Pictures speak more than words.
Before
After