Remove fallback first shipping method on shipments #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 12, 2017
| end | ||
|
|
||
| context "when a shipping rate is selected" do | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at block body beginning.
In the case where the system has not picked a shipping rate, or the user has not picked one, we can not just fall back on the first shipping rate. In this case, the "selected" shipping rate's amount and the shipment's amount will be out of sync, which is inconsistent. This commit removes the fallback.
mamhoff
force-pushed
the
do-not-just-take-the-first-method
branch
from
72a7f63 to
9718fb1
Compare
cbrunsdon
approved these changes
Apr 13, 2017
There was a problem hiding this comment.
I'm surprised this doesn't make any specs fail, I think that says a lot to some of the factory improvements we have made...
I tracked the change down to 20bed87, hoping to get some more idea on why it exists but didn't get anything reasonable. I half think it might be just to satify code if your specs did have bad factories...
I half expect someone to run into this as a problem during an upgrade, but I think its a good change over all.
tvdeyen
approved these changes
Jun 7, 2017
jhawthorn
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where the system has not picked a shipping rate, or
the user has not picked one, we can not just fall back on the first
shipping rate. In this case, the "selected" shipping rate's amount
and the shipment's amount will be out of sync, which is inconsistent.
This commit removes the fallback.