Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.1 #1895

Merged
merged 7 commits into from
Jun 8, 2017
Merged

Rails 5.1 #1895

merged 7 commits into from
Jun 8, 2017

Conversation

jhawthorn
Copy link
Contributor

No description provided.

@jhawthorn
Copy link
Contributor Author

jhawthorn commented May 17, 2017

We're now ready for Rails 5.1. All deps we need have releases compatible with rails 5.1 🎉

I'll update this PR to also be compatible with rails 5.0. EDIT: Will add rails 5.0 compatibility back later instead (if possible)

@jhawthorn jhawthorn changed the title [WIP] Rails 5.1 Rails 5.1 May 18, 2017
@jarednorman
Copy link
Member

This all looks quite sensible. 💯

@ericsaupe
Copy link
Contributor

Is it worth updating all form tags to use the new form_with? http://edgeguides.rubyonrails.org/5_1_release_notes.html#unification-of-form-for-and-form-tag-into-form-with. I know the Rails core team haven't said anything about deprecating current form tags but this is the unification of the two.

@jarednorman
Copy link
Member

I can't imagine it's worth the effort of doing that up front if the existing helpers aren't being deprecated.

@ericsaupe
Copy link
Contributor

@jarednorman that's what I thought as well. Just thought I'd bring it up!

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@peterberkenbosch
Copy link
Contributor

👍

@jhawthorn jhawthorn merged commit 142be7b into solidusio:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants