Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrating CreditCards to WalletPaymentSource #1898

Merged
merged 1 commit into from
May 9, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented May 8, 2017

Fixes #1897

Tested manually and this seems to be working. Previously this migration failed because we didn't have a payment_source association defined.

This sets the _id and _type fields directly because we want to reference the Spree::CreditCard model without using the model itself.

@jhawthorn jhawthorn added type:bug Error, flaw or fault Code review needed labels May 8, 2017
@jhawthorn jhawthorn added this to the 2.2.1 milestone May 8, 2017
@jhawthorn jhawthorn requested review from jordan-brough and mamhoff May 8, 2017 23:26
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jhawthorn jhawthorn merged commit 7c1b97a into solidusio:master May 9, 2017
@jhawthorn jhawthorn changed the title Fix migrate_credit_cards_to_wallet_payment_sources Fix migrating CreditCards to WalletPaymentSource May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error, flaw or fault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants