Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating the adjustment total including null source adjustments #1933

Conversation

alexstoick
Copy link
Contributor

@alexstoick alexstoick commented May 22, 2017

This is to help achieve #1913 - enabling admins to do refunds at line
item level instead of at order level. There is no UI for this yet, but
the functionality exists.

@alexstoick alexstoick force-pushed the feature/item-adjustments-all-adjustments branch from 5b7511a to 8831e10 Compare May 22, 2017 15:21
@alexstoick alexstoick force-pushed the feature/item-adjustments-all-adjustments branch 2 times, most recently from 7b6029a to 7692b6d Compare May 22, 2017 15:41
Copy link
Contributor

@jordan-brough jordan-brough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This feels a bit scary because it's a rather fundamental change, but I'm not sure what might break if the specs are green.

@mamhoff
Copy link
Contributor

mamhoff commented May 23, 2017

I'm not sure I understand why line item level adjustments have to be source-less.

@jordan-brough
Copy link
Contributor

jordan-brough commented May 23, 2017

@mamhoff the only other type of adjustment that solidus core generates (besides promos & taxes) are "admin" adjustments - adjustments an admin makes in the admin ui for an arbitrary reason. Right now these can only be added at the order level, and that blocks us from getting rid of order-level adjustments (thus this is linked to #1913).

Another nice improvement (but probably separate PR) might be to really support all types of adjustment sources by calling update! on adjustments that have a source other than PromotionAction/TaxRate/nil.

@jordan-brough
Copy link
Contributor

And another nice improvement beyond that might be to record something as the source for admin-generated adjustments.

@mamhoff
Copy link
Contributor

mamhoff commented May 23, 2017

Yeah, sounds good, actually. In the meantime, someone else got to editing the change log, do you mind rebasing?

This is to help achieve 1913 - enabling admins to do refunds at line
item level instead of at order level. There is no UI for this yet, but
the functionality exists.
@alexstoick alexstoick force-pushed the feature/item-adjustments-all-adjustments branch from 7692b6d to 7e13807 Compare May 23, 2017 11:01
@alexstoick
Copy link
Contributor Author

@mamhoff rebased!

@jordan-brough jordan-brough merged commit 0526f1c into solidusio:master May 23, 2017
@jordan-brough jordan-brough deleted the feature/item-adjustments-all-adjustments branch May 23, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants