-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculating the adjustment total including null source adjustments #1933
Calculating the adjustment total including null source adjustments #1933
Conversation
5b7511a
to
8831e10
Compare
7b6029a
to
7692b6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This feels a bit scary because it's a rather fundamental change, but I'm not sure what might break if the specs are green.
I'm not sure I understand why line item level adjustments have to be source-less. |
@mamhoff the only other type of adjustment that solidus core generates (besides promos & taxes) are "admin" adjustments - adjustments an admin makes in the admin ui for an arbitrary reason. Right now these can only be added at the order level, and that blocks us from getting rid of order-level adjustments (thus this is linked to #1913). Another nice improvement (but probably separate PR) might be to really support all types of adjustment sources by calling |
And another nice improvement beyond that might be to record something as the |
Yeah, sounds good, actually. In the meantime, someone else got to editing the change log, do you mind rebasing? |
This is to help achieve 1913 - enabling admins to do refunds at line item level instead of at order level. There is no UI for this yet, but the functionality exists.
7692b6d
to
7e13807
Compare
@mamhoff rebased! |
This is to help achieve #1913 - enabling admins to do refunds at line
item level instead of at order level. There is no UI for this yet, but
the functionality exists.