Allow admin to edit variant option values #1944
Conversation
This reverts commit ce10040. We want to allow admins to have maximum flexibility when editing variants.
|
@dividedharmony this doesn't seem to address some of the concerns that @mamhoff raised in his commit. He mentioned that with the form, an admin:
Is that not still a danger? |
|
@jordan-brough Good point. I can add a validation such that OptionValuesVariants are unique within the scope of any given product. |
|
@jordan-brough yes that could still happen, but I've since been convinced that admins should have that power. For example, stores that model packaging via variant options might want to change how a variant is packaged (in a bag or a carton) without having to re-create the variant and possibly losing the connection to the previous packaging for analytics. |
| <% end %> | ||
| <fieldset class="no-border-top no-border-bottom"> | ||
| <% @product.option_types.each_with_index do |option_type, index| %> | ||
| <div class="field four columns <%= 'alpha' if index % 3 == 0 %><%= 'omega' if index % 3 == 2 %>" data-hook="presentation"> |
There was a problem hiding this comment.
This goes back to using the skeleton classes. Can this be updated to use the bootstrap classes (as the removed code did)
With the previous revert, this form went back to the old skeleton CSS classes. This commit changes those classes to the new and preferred Bootstrap CSS classes.
|
@jhawthorn Thanks for pointing that out! I've switched back over to the Bootstrap way of doing things. |
This PR reverts ce10040 which, on the edit admin product variants form, hid the ability to edit an existent variant's option value from the admin. However, we want maximize the flexibility for admins to edit variants. Thus, we should display this fieldset to the admin.