Re-add deprecated TaxRate#tax_category #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
tax_rate_tax_category_deprecation
branch
from
590917d to
5acf29e
Compare
houndci-bot
reviewed
Jun 12, 2017
core/app/models/spree/tax_rate.rb
Outdated
| end | ||
|
|
||
| def tax_category | ||
| self.tax_categories[0] |
jhawthorn
force-pushed
the
tax_rate_tax_category_deprecation
branch
from
5acf29e to
a7356a8
Compare
tvdeyen
approved these changes
Jun 14, 2017
This was removed when the association was changed to a many-to-many. It's easy enough for us to provide the basic accessors as deprecated methods.
jhawthorn
changed the title
jhawthorn
force-pushed
the
tax_rate_tax_category_deprecation
branch
from
a7356a8 to
d0aaead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed when the association was changed to a many-to-many (#1851). It's easy enough for us to provide the basic accessors as deprecated methods.