Remove ! from assign_default_user_addresses! #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no version of this method without an exclamation mark. Additionally, this doesn't have any of the normal tells of a ! method, it doesn't make changes to the database, shouldn't raise exceptions, and doesn't do anything "dangerous". This commit renames the method to assign_default_user_addresses, and adds assign_default_user_addresses! as a deprecated alias.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion when reviewing #1967 about whether
assign_default_user_addresses!would persist changes or not. It doesn't, but the!suggests that it might.There's no version of this method without an exclamation mark. Additionally, this doesn't have any of the normal tells of a ! method, it doesn't make changes to the database, shouldn't raise exceptions, and
doesn't do anything "dangerous".
This commit renames the method to
assign_default_user_addresses, and keepsassign_default_user_addresses!as a deprecated alias. It also adds some YARD docs to the method.