Validate presence of product on a Variant #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Jun 15, 2017
core/app/models/spree/variant.rb
Outdated
| @@ -61,6 +61,7 @@ class Variant < Spree::Base | |||
|
|
|||
| validate :check_price | |||
|
|
|||
| validates :product, presence: true | |||
There was a problem hiding this comment.
Can't we instead use optional: false on the belongs_to :product above?
jhawthorn
force-pushed
the
validate_product
branch
from
f932f86 to
39c7a77
Compare
mamhoff
approved these changes
Jun 21, 2017
gmacdougall
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might also make sense to add a DB constraint.
Fixes #2011