Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace select2 with <select class="custom-select"> #2034

Merged
merged 24 commits into from
Jun 28, 2017
Merged

Replace select2 with <select class="custom-select"> #2034

merged 24 commits into from
Jun 28, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Jun 21, 2017 •
edited
Loading

This replaces the select2 component with a plain <select> (with bootstrap's custom-select styling) throughout the admin.

@jhawthorn jhawthorn added changelog:solidus_backend Changes to the solidus_backend gem WIP labels Jun 21, 2017
@jhawthorn jhawthorn changed the title [WIP] Replace select2 with custom-select Replace select2 with <select class="custom-select"> Jun 22, 2017
@jhawthorn jhawthorn removed the WIP label Jun 22, 2017
jhawthorn and others added 24 commits June 22, 2017 14:05
@jhawthorn
Replace select2 with custom-select on stores#edit
7498afd
@jhawthorn
Replace select.select2 on product pages
7c43a13
@jhawthorn
Replace select2 on orders pages
ff96623
@jhawthorn
Replace select2 on variant pages
50f5597
@jhawthorn
Prices
466d435
@jhawthorn
Replace select2 in promotions
a829fde
@jhawthorn
Promotions
71b010c
@jhawthorn
Remove select2 from product properties
995c1fa
@jhawthorn
Use custom-select for variant search
c4ba3be
@jhawthorn
Use custom-select for calculator fields
6009490
@jhawthorn
Use custom-select on shipping methods page
2435c87
@jhawthorn
Use custom-select on tax rates page
6f5997b 
This doesn't remove select2 from the tax_rate_ids input, since that is a
multiple select.
@jhawthorn
Use custom-select in payment methods
1134199
@jhawthorn
Use custom-select in payment method
7898d7f
@jhawthorn
Use custom-select in returns and reimbursements
4f4043e
@jhawthorn
Use custom-select in refunds
5abedc7
@jhawthorn
Fixup to shipping methods calculator
ac26992
@jhawthorn
Use custom-select for stock_transfers
a88216a
@jhawthorn
Use custom-select for adjustments
34524e5
@jhawthorn
Use select2 for states
36cea9f
@jhawthorn
Remove select2 from style guide
c819dca
@jhawthorn
Use custom-select for store_credits
05a4a24
@jhawthorn
Use custom-select in images
29cb1e5
@jhawthorn
Use custom-select in stock_items
3cb19c7
@mtomov
Copy link
Contributor

mtomov commented Jun 22, 2017 •
edited
Loading

Hm.. Ain't it a more valid approach to style all select with your custom styles, but maybe add a no-custom-style or so class for those occasions when you want to opt out of it. That should make it easier for developers as they won't have to learn about this new class unless they have a very very special case to "opt out". Would certainly help extensions as well.

Edit: Sorry misread the PR, ignore the above - so there's actually no additional styling that comes with this new class custom-select .. then why do we need it at all is my new question?

@jhawthorn
Copy link
Contributor Author

custom-select has styling from bootstrap. It is somewhat heavy handed, so we probably don't want to @extend it onto every select element.

This was referenced Jun 27, 2017
Merged
Closed
@gmacdougall gmacdougall merged commit 55a72e7 into solidusio:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhawthorn @mtomov @gmacdougall