Use @collection instead of @collection.present? in some admin controllers
#2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty sure `defined?` was the intended behavior. Using `present?` can generate an extra query for the presence check, and will also prevent the instance-variable caching from working when the query returns no results.
jhawthorn
approved these changes
Jun 27, 2017
Should work equally well in these cases
tvdeyen
approved these changes
Jun 27, 2017
jordan-brough
changed the title
defined? instead of present? in some admin controllers@collection instead of @collection.present? in some admin controllers
Good point, I've updated to that. |
mamhoff
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure
defined?was the intended behavior.Using
present?can generate an extra query for the presence check, and willalso prevent the instance-variable caching from working when the query returns
no results.