Fixed insufficient inventory error message. #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. We've had an issue with our circle configuration which should be resolved now. Could you please rebase this on to master if you have a moment? |
This spec wasn't testing anything, it never confirmed the split it was setting up. The accept_alert errored on some drivers because no error was raised.
Previously, if a shipment split failed, the page would issue an
alert(undefined). It would never alert with a proper error.
This failed on the capybara selenium driver because it was confused
about getting undefined.
This replaces
alert(undefined)
with
alert("Unable to complete split")
Which is a little better (admittedly not much) for users, but doesn't
confuse the selenium test driver.
Having text fields concatenated together is a poltergeist specific behaviour. Fortunately, asserting on the page title is a lot cleaner and just as effective.
Under selenium this spec wasn't working because it didn't click "ok" on the confirmation dialog. Also fixes a before block which wasn't running (which didn't affect the accuracy of the test, but did make it slightly slower).
|
Tests pass with things fixed up. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.