Avoid running validations in current_order

[jhawthorn]

Previously we updated the IP address on each request by calling

update(last_ip_address: ip_address)

Though this doesn't run a SQL UPDATE if not necessary, it will still run validations (resulting in two SELECTs).

This commit adds a new record_ip_address(ip_address) method to Spree::Order, which will only update the ip_address if it has changed.

This also switches update to update_attributes!, so that any errors will be raised.

Before

  Spree::Order Load (0.2ms)  SELECT  "spree_orders".* FROM "spree_orders" WHERE "spree_orders"."completed_at" IS NULL AND "spree_orders"."currency" = ? AND "spree_orders"."guest_token" = ? AND "spree_orders"."store_id" = ? AND "spree_orders"."user_id" = ? LIMIT ?  [["currency", "USD"], ["guest_token", "aCYxT9EsjJSLEoxCaFLCmA"], ["store_id", 1], ["user_id", 1], ["LIMIT", 1]]
  Spree::Adjustment Load (0.1ms)  SELECT "spree_adjustments".* FROM "spree_adjustments" WHERE "spree_adjustments"."adjustable_type" = ? AND "spree_adjustments"."adjustable_id" = 5 ORDER BY "spree_adjustments"."created_at" ASC  [["adjustable_type", "Spree::Order"]]
   (0.0ms)  begin transaction
  Spree::Store Load (0.0ms)  SELECT  "spree_stores".* FROM "spree_stores" WHERE "spree_stores"."id" = ? LIMIT ?  [["id", 1], ["LIMIT", 1]]
  Spree::Order Exists (0.1ms)  SELECT  1 AS one FROM "spree_orders" WHERE "spree_orders"."number" = ? AND ("spree_orders"."id" != ?) LIMIT ?  [["number", "R097935381"], ["id", 5], ["LIMIT", 1]]
   (0.0ms)  commit transaction

After

  Spree::Order Load (0.2ms)  SELECT  "spree_orders".* FROM "spree_orders" WHERE "spree_orders"."completed_at" IS NULL AND "spree_orders"."currency" = ? AND "spree_orders"."guest_token" = ? AND "spree_orders"."store_id" = ? AND "spree_orders"."user_id" = ? LIMIT ?  [["currency", "USD"], ["guest_token", "aCYxT9EsjJSLEoxCaFLCmA"], ["store_id", 1], ["user_id", 1], ["LIMIT", 1]]
  Spree::Adjustment Load (0.2ms)  SELECT "spree_adjustments".* FROM "spree_adjustments" WHERE "spree_adjustments"."adjustable_type" = ? AND "spree_adjustments"."adjustable_id" = 5 ORDER BY "spree_adjustments"."created_at" ASC  [["adjustable_type", "Spree::Order"]]

[tvdeyen]

👍

[tvdeyen]

Or simply update!

[mamhoff]

We've overriden update!. :)

[tvdeyen]

We are strange :)