Invalidate existing non store credit payments during checkout #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 11, 2017
| source: payment_source, | ||
| order: order, | ||
| amount: 5 | ||
| ) |
There was a problem hiding this comment.
Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
| source: existing_payment_source, | ||
| order: order, | ||
| amount: 5 | ||
| ) |
There was a problem hiding this comment.
Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
tvdeyen
changed the title
tvdeyen
force-pushed
the
do-not-allow-multiple-payments
branch
from
8e11b15 to
438c997
Compare
mamhoff
approved these changes
Jul 11, 2017
tvdeyen
force-pushed
the
do-not-allow-multiple-payments
branch
from
438c997 to
6c88998
Compare
|
Waits for #2076 |
jordan-brough
approved these changes
Jul 12, 2017
tvdeyen
force-pushed
the
do-not-allow-multiple-payments
branch
from
6c88998 to
f46a1ca
Compare
tvdeyen
force-pushed
the
do-not-allow-multiple-payments
branch
from
f46a1ca to
149cd5d
Compare
kennyadsl
approved these changes
Aug 9, 2017
The spec setup for the order payment spec creates multiple payments that all have a different payment method ids because the factory creates a new payment method object for each payment. By using the same payment method for all payments we test what actually happens during checkout.
In order to refactor the Payment#invalidate_old_payments method we need more test coverage.
Existing payments other then store credit ones should be invalidated when creating new payments.
When creating a new payment for an order having existing payments we want all previous payments in checkout state to be invalidated; except if they are store credit payments. Former implementation only invalidated payments with same payment method. That led to multiple valid payments per order for stores having more then one payment method available for customers to choose from.
tvdeyen
force-pushed
the
do-not-allow-multiple-payments
branch
from
149cd5d to
b15ab06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new payment for an order having existing payments
we want all previous payments in checkout state to be invalidated; except
if they are store credit payments.
Former implementation only invalidated payments with same payment method.
That led to multiple valid payments per order for stores having more then
one payment method available for customers to choose from.