Check if deprecated method_type if overridden #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
method_type has been deprecated in favour of the more descriptive partial_name. There is a deprecation notice when method_type is called, but there isn't when method_type is overridden (which is very likely for custom gateway implementations). This commit checks if method_type has been overridden, and if so, uses that instead of the default value of partial_name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method_type has been deprecated in favour of the more descriptive partial_name. There is a deprecation notice when method_type is called, but there isn't when method_type is overridden (which is very likely for
custom gateway implementations).
This commit checks if method_type has been overridden, and if so, uses that instead of the default value of partial_name.
This fixed both
solidus_gatewayandsolidus_braintreeon latest master (and provided warnings of how best to move forward), so I imagine it is likely to be helpful for users.