Default to static preferences #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this also affect extension's |
It will. One of the motivations for it. |
cbrunsdon
approved these changes
Jul 26, 2017
jhawthorn
force-pushed
the
default_static_preferences
branch
from
547b42f to
6f88c5f
Compare
We've included static preferences for a while, and they've been default for new stores. This commit makes the static preferences store the default with no additional configuration. It also adds a way for stores to opt-in to the legacy DB-driven behaviour.
use_static_preferences! is now the default
jhawthorn
force-pushed
the
default_static_preferences
branch
from
6f88c5f to
fc85620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've included static preferences for a while, and they've been default for new stores, but required a call to
use_static_preferences!This commit makes the static preferences store the default with no additional configuration. It also adds a way for stores to opt-in to the legacy DB-driven behaviour.
If accepted this should have a prominent changelog entry.