Fix error when passing coupon_code to api/checkouts#update #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 8, 2017
| order.update_column(:state, "payment") | ||
| put spree.api_checkout_path(order.to_param), params: { order_token: order.guest_token, order: { coupon_code: "foobar" } } | ||
| expect(response.status).to eq(422) | ||
| expect(json_response).to eq({"error"=>"The coupon code you entered doesn't exist. Please try again."}) |
There was a problem hiding this comment.
Space inside { missing.
Surrounding space missing for operator =>.
Space inside } missing.
jhawthorn
force-pushed
the
checkouts_controller_coupon_api_fix
branch
from
b37b745 to
7146f76
Compare
tvdeyen
approved these changes
Aug 9, 2017
kennyadsl
approved these changes
Aug 9, 2017
|
Merged as part of #2139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when given a
coupon_code, this action would always error.handlerwasn't thePromotionHandler, but the return value ofapply(a hash). This has been the case since Spree 2.2.The error wasn't noticed in specs because of the rescue_from in BaseController, which I am working on removing.
This also makes the return status of a real coupon application error (which previously was inaccessible) 422.