Convert admin RABL views to Jbuilder #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Aug 10, 2017
backend/solidus_backend.gemspec
Outdated
| @@ -31,6 +31,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'jquery-ui-rails', '~> 5.0.0' | |||
| s.add_dependency 'font-awesome-rails', '~> 4.0' | |||
| s.add_dependency 'kaminari', '>= 0.17', '< 2.0' | |||
| s.add_dependency 'jbuilder' | |||
jhawthorn
force-pushed
the
admin_jbuilder
branch
from
b451351 to
1891ac9
Compare
tvdeyen
approved these changes
Aug 11, 2017
jhawthorn
force-pushed
the
admin_jbuilder
branch
from
1891ac9 to
4424d2f
Compare
|
When you see anything that looks like this: |
Yeah, JBuilder uses this (maybe too) cleverly as a shorthand for multiple attributes. I replaced a few spots where it didn't make sense to use this over explicitly declaring the attributes on separate lines. |
JuanCrg90
added a commit
to JuanCrg90/solidus
that referenced
this pull request
Nov 10, 2019
RABL was removed from the project on version 2.4.0 (See solidusio#2147 solidusio#2146). This updates the responder template to match with Jbuilder and updates the README file.
JuanCrg90
added a commit
to JuanCrg90/solidus
that referenced
this pull request
Nov 15, 2019
RABL was removed from the project on version 2.4.0 (See solidusio#2147 solidusio#2146). This updates the responder template to match with Jbuilder and updates the README file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.