Bootstrap 4.0.0-beta #2156
Merged
Bootstrap 4.0.0-beta #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
bootstrap-4-beta
branch
from
6d08131 to
95adccc
Compare
cbrunsdon
approved these changes
Aug 15, 2017
jhawthorn
force-pushed
the
bootstrap-4-beta
branch
from
95adccc to
555669f
Compare
Variable changes:
s/font-size-h1/h1-font-size/
s/\$brand-\(primary\|secondary\|success\|info\|warning\|danger\|light\|dark\)/theme-color("\1")/g
s/input-border-focus/input-focus-border-color/
s/input-bg-disabled/input-disabled-bg/
s/input-color-placeholder/input-placeholder-color
Use grid-gutter-width instead of grid-gutter-widths
Use input-btn-padding and input-btn-line-height
I don't know why bootstrap uses -btn- for these, as they're used for all
.form-control inputs also.
Also improves select2 custom styling
jhawthorn
force-pushed
the
bootstrap-4-beta
branch
from
555669f to
e7cb973
Compare
jhawthorn
force-pushed
the
bootstrap-4-beta
branch
from
e7cb973 to
273d1ef
Compare
|
Updated to include the merged #2133 |
|
Hi, How can I use bootstrap in my application (frontend)? |
|
Damagoza: To use bootstrap, you have to customize the frontend. See https://www.youtube.com/watch?v=kFalBLRMgdI for more information. Github issues are meant to inform about bugs and/or missing features, by the way. For support questions like this, please use our Slack channel (solidusio.slack.com). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap 4.0.0 has entered beta! Hopefully that means this is the last PR with such significant changes to scss variable naming 😥
This required including
autoprefixer-railsas a dependency. We probably should have done this for previous versions, but it is now necessary even for latest browsers.This required some variable changes. Briefly:
TODO