Use constants instead of translations for StoreCreditType names
#2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no great reason for `StoreCreditType::DEFAULT_TYPE_NAME` to be defined with a translation. The translation isn't being used to construct error messages or sent to the frontend at all.
It makes more sense to use the constants defined in `StoreCreditType`.
The `StoreCreditType::DEFAULT_TYPE_NAME` is the expiring type. Instead of having a string as the `secondary_credit_type#name` use the constant defined in `StoreCreditType`.
cbrunsdon
approved these changes
Aug 16, 2017
mamhoff
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be a great reason for
StoreCreditType::DEFAULT_TYPE_NAMEto be defined with a translation. The translation isn't being used to construct error messages or sent to the frontend at all.This PR defines two constants in
StoreCreditType,StoreCreditType::EXPIRINGandStoreCreditType::NON_EXPIRING, and uses them in the appropriate places.